Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use raw api-report rollup d.ts #5397

Merged
merged 2 commits into from
Aug 30, 2021
Merged

use raw api-report rollup d.ts #5397

merged 2 commits into from
Aug 30, 2021

Conversation

Feiyang1
Copy link
Member

Fixes #5392

repo-scripts/prune-dts/prune-dts.ts removes inherited constructors, which makes the typings of classes incorrect.
This is a temporary fix, and will expose some internal types to developers. We should fix the prune-dts.ts to handle constructors correctly.

@schmidt-sebastian fyi

@changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2021

🦋 Changeset detected

Latest commit: 6343ba7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2021

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 27, 2021

Size Analysis Report

Affected Products

No changes between base commit (509c18f) and head commit (5917085).

@Feiyang1 Feiyang1 requested a review from egilmorez as a code owner August 27, 2021 23:20
@Feiyang1 Feiyang1 merged commit 66596f3 into master Aug 30, 2021
@Feiyang1 Feiyang1 deleted the fei-fix-auth-types branch August 30, 2021 17:38
@jpike88
Copy link

jpike88 commented Aug 30, 2021

@Feiyang1 are my comments on #5392 applicable to this PR?

@google-oss-bot google-oss-bot mentioned this pull request Aug 30, 2021
@firebase firebase locked and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OAuthProvider is missing constructor
4 participants